Dandandan commented on a change in pull request #288:
URL: https://github.com/apache/arrow-datafusion/pull/288#discussion_r629276518
##########
File path: datafusion/src/physical_plan/datetime_expressions.rs
##########
@@ -268,6 +268,13 @@ pub fn to_timestamp(args: &[ColumnarValue]) ->
Result<ColumnarValue> {
)
}
+/// now SQL function
+pub fn now(_: &[ColumnarValue]) -> Result<ColumnarValue> {
+ Ok(ColumnarValue::Scalar(ScalarValue::TimestampNanosecond(
+ Some(chrono::Utc::now().timestamp_nanos()),
Review comment:
I think this needs access too to the `ExecutionProps` so it can use the
query start timestamp here.
We can add a test that disables the optimizer rule(s) to show this still
resolves to the same value as in `ExecutionProps` and has the same value for
`SELECT NOW() one, NOW() two`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
