msathis commented on a change in pull request #288:
URL: https://github.com/apache/arrow-datafusion/pull/288#discussion_r629301375



##########
File path: datafusion/src/physical_plan/datetime_expressions.rs
##########
@@ -268,6 +268,13 @@ pub fn to_timestamp(args: &[ColumnarValue]) -> 
Result<ColumnarValue> {
     )
 }
 
+/// now SQL function
+pub fn now(_: &[ColumnarValue]) -> Result<ColumnarValue> {
+    Ok(ColumnarValue::Scalar(ScalarValue::TimestampNanosecond(
+        Some(chrono::Utc::now().timestamp_nanos()),

Review comment:
       Thanks @Dandandan . I just started working on this. But finding it quite 
difficult to pass `ExecutionProps` to these functions. There are multiple types 
of `ExecutionPlan`. Do i need to add a reference of `ExecutionProps` to all of 
these?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to