dmitry-chirkov-dremio commented on code in PR #49951:
URL: https://github.com/apache/arrow/pull/49951#discussion_r3425159784
##########
cpp/src/gandiva/tests/in_expr_test.cc:
##########
@@ -221,6 +221,62 @@ TEST_F(TestIn, TestInDecimal) {
EXPECT_ARROW_ARRAY_EQUALS(exp, selection_vector->ToArray());
Review Comment:
Some of the preexisting test coverage across Gandiva makes me sad at time so
let's use the opportunity to beef it up a bit. Even GitHub's free Haiku should
be able to suggest couple of cases and couple of edge cases. And yes, if you
are using an agent - nudge it to maintain existing assert/comparison style as
kou says.
p.s. rest is good and I'll be able to approve once comments are addressed -
good find/fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
