Reranko05 commented on code in PR #49951:
URL: https://github.com/apache/arrow/pull/49951#discussion_r3425801785
##########
cpp/src/gandiva/tests/in_expr_test.cc:
##########
@@ -221,6 +221,62 @@ TEST_F(TestIn, TestInDecimal) {
EXPECT_ARROW_ARRAY_EQUALS(exp, selection_vector->ToArray());
Review Comment:
Thanks! I incorporated the cached object code path into the existing
`TestInDecimal `coverage and updated the assertions to follow the existing
`ASSERT_OK` style as suggested by @kou. I agree that Gandiva tests could
benefit from more edge-case coverage, but I kept this PR focused on the
GH-39784 regression and its cache path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
