pitrou commented on code in PR #50269: URL: https://github.com/apache/arrow/pull/50269#discussion_r3537949328
########## cpp/src/arrow/util/ree_util.h: ########## @@ -57,6 +57,13 @@ Status ValidateRunEndEncodedChildren(const RunEndEncodedType& type, /// \brief Compute the logical null count of an REE array int64_t LogicalNullCount(const ArraySpan& span); +/// \brief Populate a bitmap based on the logical nulls in an REE array +/// +/// \param set_on_null true if we should set bits corresponding to nulls and false if +/// we should set bits corresponding to non-nulls +void SetLogicalNullBits(const ArraySpan& span, uint8_t* out_bitmap, int64_t out_offset, Review Comment: I think you'll need `ARROW_EXPORT` on these new functions to avoid the linking errors on Windows, btw. (we should probably go ahead and do it for the other non-inline functions in these headers btw) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
