hadrian-reppas commented on code in PR #50269:
URL: https://github.com/apache/arrow/pull/50269#discussion_r3538237834
##########
cpp/src/arrow/util/dict_util.cc:
##########
@@ -78,5 +104,48 @@ int64_t LogicalNullCount(const ArraySpan& span) {
return LogicalNullCount<Int64Type>(span);
}
}
+
+void SetLogicalNullBits(const ArraySpan& span, uint8_t* out_bitmap, int64_t
out_offset,
+ bool set_on_null) {
+ if (span.dictionary().GetNullCount() == 0 || span.length == 0) {
Review Comment:
Yeah this feels kind of odd. I think we should probably be calling
`ComputeLogicalNullCount` in both `LogicalNullCount` and `SetLogicalNullBits`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
