hadrian-reppas commented on code in PR #50269:
URL: https://github.com/apache/arrow/pull/50269#discussion_r3540574781
##########
cpp/src/arrow/util/dict_util.cc:
##########
@@ -78,5 +104,48 @@ int64_t LogicalNullCount(const ArraySpan& span) {
return LogicalNullCount<Int64Type>(span);
}
}
+
+void SetLogicalNullBits(const ArraySpan& span, uint8_t* out_bitmap, int64_t
out_offset,
+ bool set_on_null) {
+ if (span.dictionary().GetNullCount() == 0 || span.length == 0) {
Review Comment:
Actually, things become kind of messy if you look at logical nulls in the
dictionary. Right now, it just looks at the dictionary validity bitmap. But if
we wanted to properly handle logical nulls, we would need to deal with
dictionaries that are dictionary, ree, and union types. So I'll keep this
behavior for now and add a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
