Copilot commented on code in PR #50555: URL: https://github.com/apache/arrow/pull/50555#discussion_r3614558585
########## cpp/thirdparty/versions.txt: ########## @@ -80,8 +80,8 @@ ARROW_JEMALLOC_BUILD_VERSION=5.3.0 ARROW_JEMALLOC_BUILD_SHA256_CHECKSUM=2db82d1e7119df3e71b7640219b6dfe84789bc0537983c3b7ac4f7189aecfeaa ARROW_LZ4_BUILD_VERSION=v1.10.0 ARROW_LZ4_BUILD_SHA256_CHECKSUM=537512904744b35e232912055ccf8ec66d768639ff3abe5788d90d792ec5f48b -ARROW_MIMALLOC_BUILD_VERSION=v3.3.1 -ARROW_MIMALLOC_BUILD_SHA256_CHECKSUM=42c16914168ac6741eeb407e83b93a12b2b7ee25a7e14e6b4807fab8b577a540 +ARROW_MIMALLOC_BUILD_VERSION=v3.4.1 +ARROW_MIMALLOC_BUILD_SHA256_CHECKSUM=37107a52c16baa80c5f74861dddda7b27bb9949e41a6637691867a94c88ca446 Review Comment: After bumping the bundled mimalloc version, there’s still a version-specific note in `cpp/cmake_modules/ThirdpartyToolchain.cmake` that says a MinGW workaround is “still required as of mimalloc 3.3.1” (line ~2561). That comment is now stale/misleading; please update it (either to 3.4.1 or to a version-agnostic phrasing) so future maintainers don’t assume the workaround was only validated on 3.3.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
