Copilot commented on code in PR #50555:
URL: https://github.com/apache/arrow/pull/50555#discussion_r3615406141
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -2567,8 +2567,15 @@ if(ARROW_MIMALLOC)
"-DCMAKE_C_FLAGS=${MIMALLOC_C_FLAGS}"
"-DCMAKE_INSTALL_PREFIX=${MIMALLOC_PREFIX}"
-DMI_INSTALL_TOPLEVEL=ON
+ # Don't override default malloc
-DMI_OVERRIDE=OFF
+ -DMI_OSX_INTERPOSE=OFF
+ -DMI_OSX_ZONE=OFF
Review Comment:
The PR description says this is only a mimalloc version bump, but this hunk
also changes mimalloc build behavior (explicitly disabling malloc overriding on
all platforms, and adjusting macOS override mechanisms / TLS settings). Please
either (a) update the PR description (and any release note expectations) to
call out these behavioral changes and their rationale/impact, or (b)
split/reduce the change so this PR is strictly a version bump.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
