thisisnic commented on a change in pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#discussion_r635854937
##########
File path: r/R/table.R
##########
@@ -175,12 +175,17 @@ Table$create <- function(..., schema = NULL) {
return(dplyr::group_by(out, !!!dplyr::groups(dots[[1]])))
Review comment:
I was thinking it's OK that there's no scalar recycling with a
grouped_df as scalar recycling only happens when there's >1 input passed in,
and grouping only happens when there's 1 input passed in.
Using tibble/dplyr, I get `FALSE` if I call `tibble::tibble(slice(iris,1),
group_by(iris, Species), .name_repair = "unique") %>% is_grouped_df()`, so this
I think this is what we want?
I've refactored the code so things are more in keeping with the early return
style & only 1 Table__from_dots call now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
