thisisnic commented on a change in pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#discussion_r633850677
##########
File path: r/R/record-batch.R
##########
@@ -161,7 +161,18 @@ RecordBatch$create <- function(..., schema = NULL) {
out <- RecordBatch__from_arrays(schema, arrays)
return(dplyr::group_by(out, !!!dplyr::groups(arrays[[1]])))
}
-
+
+ # If any arrays are length 1, recycle them
Review comment:
I opened up a ticket to do this in C++, so I figured probably no point
duplicating that effort? Though if this seems like a special case that's better
off implemented in the R package's C++ layer rather than the source C++, I can
look into it. See discussion on this ticket, @nealrichardson :
https://issues.apache.org/jira/browse/ARROW-12789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
