Jefffrey commented on code in PR #10994:
URL: https://github.com/apache/arrow-rs/pull/10994#discussion_r3938852431
##########
arrow-select/src/take.rs:
##########
@@ -339,6 +339,12 @@ fn take_impl<IndexType: ArrowPrimitiveType, const CHECKED:
bool>(
}
}
DataType::Union(fields, UnionMode::Sparse) => {
+ if indices.null_count() > 0 && fields.iter().any(|(_, field)|
!field.is_nullable()) {
Review Comment:
i think this is an existing issue with union builders?
-https://github.com/apache/arrow-rs/issues/1637
##########
arrow-select/src/take.rs:
##########
@@ -339,6 +339,12 @@ fn take_impl<IndexType: ArrowPrimitiveType, const CHECKED:
bool>(
}
}
DataType::Union(fields, UnionMode::Sparse) => {
+ if indices.null_count() > 0 && fields.iter().any(|(_, field)|
!field.is_nullable()) {
Review Comment:
i think this is an existing issue with union builders?
- https://github.com/apache/arrow-rs/issues/1637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
