Jefffrey commented on code in PR #10994:
URL: https://github.com/apache/arrow-rs/pull/10994#discussion_r3938916190
##########
arrow-select/src/take.rs:
##########
@@ -339,6 +339,12 @@ fn take_impl<IndexType: ArrowPrimitiveType, const CHECKED:
bool>(
}
}
DataType::Union(fields, UnionMode::Sparse) => {
+ if indices.null_count() > 0 && fields.iter().any(|(_, field)|
!field.is_nullable()) {
Review Comment:
technically this might be too strict? as long as we have one child that is
nullable we can select that type id, then for the rest we fill in nulls or some
default; it shouldnt matter since they arent the selected child, even if their
values arent null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
