Jefffrey commented on PR #10994: URL: https://github.com/apache/arrow-rs/pull/10994#issuecomment-5548430052
from a codex review it identified 2 edge cases: - for structs with non-nullable ree/union, currently we reject these because we try to take on them, even though we can mask them with the structs own null buffer (overly strict) - if we have nested unions where inner union has no nullable children, but as a field in the outer union it is marked as nullable, we can incorrect select it to be the null child (e.g. for dense unions) (these are pretty extreme edge cases honestly, i wouldnt mind them being a separate issue; just wanted to point out for completeness) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
