etseidl commented on PR #11267: URL: https://github.com/apache/arrow-rs/pull/11267#issuecomment-5936743027
> Money aside, I’m not sure that’s really what we want, TBH. Regressions can show up in unexpected places, and running the full benchmark suite does a good job of making sure they don’t go unnoticed. Oh, for sure, but my point was a) my curiosity has been satified so no need to run the full suite again for this PR, and b) during development we should be running targeted benches to gauge value-add. The full suite should be run before merge or release to catch any missed regressions. > In any case, when we do want to run everything, we should be able to. https://github.com/adriangb/datafusion-benchmarking/pull/44 exports the critcmp report to a Gist whenever it’s too large to fit in a GitHub comment. 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
