alamb commented on code in PR #11267:
URL: https://github.com/apache/arrow-rs/pull/11267#discussion_r4185906491
##########
parquet/Cargo.toml:
##########
@@ -94,6 +94,9 @@ object_store = { workspace = true, features = ["azure", "fs"]
}
opendal = { version = "0.59.1", default-features = false, features =
["services-memory"] }
sysinfo = { version = "0.39.6", default-features = false, features =
["system"] }
+[target.'cfg(target_os = "linux")'.dev-dependencies]
Review Comment:
I think we should please do it as its own PR so we can discuss and document
it properly. It sounds like a good change, but one that I think deserves its
own discussion / wider attention than in a PR to add new benchmarks as it may
affect (for the better) benchmarking for multiple crates
> On my benchmark host, I can reliably observe up to ~2x performance drift
based solely on benchmark execution order. In practice, that means cargo bench
arrow_writer and cargo bench arrow_writer -- some_filter can produce materially
different results for the same matching benchmarks, depending on whether
allocator caches have already been warmed up by earlier benchmarks in the
invocation that filters.
Yes, I have seen this before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
