etseidl commented on PR #11267: URL: https://github.com/apache/arrow-rs/pull/11267#issuecomment-5943057522
> Perhaps we should append `_non_null` to the fixed-cardinality string benchmark names to make that distinction clearer and align them with that naming convention? I'm not sure about changing names of existing benches, as that makes things difficult to compare if you want to go back to an older branch. Guess we should have checked naming more closely before. If anything I'd think add "25pct_null" to the 1pct names. @alamb to you care to chime in here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
