etseidl commented on code in PR #11297:
URL: https://github.com/apache/arrow-rs/pull/11297#discussion_r4160672562
##########
parquet/src/file/metadata/mod.rs:
##########
@@ -333,28 +329,57 @@ impl PartialEq for ParquetMetaData {
/// .add_row_group(last_row_group)
/// .build();
/// ```
-pub struct ParquetMetaDataBuilder(ParquetMetaData);
+pub struct ParquetMetaDataBuilder {
+ /// File level metadata
+ file_metadata: Arc<FileMetaData>,
Review Comment:
I originally did have un-Arc'd members here, but then you run into issues of
cloning things you perhaps don't need to. Keeping members wrapped in their Arcs
then is only an issue if we want to mutate them. Keep it CoW-ish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
