etseidl commented on code in PR #11297: URL: https://github.com/apache/arrow-rs/pull/11297#discussion_r4161284304
########## parquet/src/file/metadata/mod.rs: ########## @@ -116,15 +116,18 @@ pub(crate) use writer::ThriftMetadataWriter; /// This structure is read by the various readers in this crate or can be read /// directly from a file using the [`ParquetMetaDataReader`] struct. /// +/// The individual fields of this structure are stored in a way that make cloning +/// this structure low-cost. Review Comment: Worth noting that it's not no cost. The `FileDecryptor` is `Box`ed, not `Arc`d, so it is cloned. But the innards of `FileDecryptor` are mostly `Arc`s themselves, with the exception of the `file_aad`, which is essentially a string. A single string copy shouldn't break the bank. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
