etseidl commented on code in PR #11297:
URL: https://github.com/apache/arrow-rs/pull/11297#discussion_r4161324039
##########
parquet/src/file/metadata/thrift/encryption.rs:
##########
@@ -296,12 +296,16 @@ pub(crate) fn parquet_metadata_with_encryption(
.map_err(|e| general_err!("Could not parse metadata: {}", e))?;
let ParquetMetaData {
- mut file_metadata,
+ file_metadata,
row_groups,
page_index: _,
file_decryptor: _,
} = parquet_meta;
+ // this is called right after creating parquet_meta, so there should be no
other references
Review Comment:
got around this awkwardness by adding a new fn to return the raw parts.
https://github.com/apache/arrow-rs/pull/11297/commits/96238ebccc39d9fe1542471d81dc40ca573ab224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]