efegokdemir commented on code in PR #11209:
URL: https://github.com/apache/arrow-rs/pull/11209#discussion_r4165390768
##########
arrow-data/src/transform/mod.rs:
##########
@@ -843,6 +843,16 @@ impl<'a> MutableArrayData<'a> {
));
}
+ if len == 0 {
+ return Ok(());
+ }
+
+ if matches!(&self.data.data_type, DataType::Union(fields, _) if
fields.is_empty()) {
Review Comment:
Cargo validation is now available and passed on the current tip
`50f611a4`:\n\n- `cargo fmt --all -- --check` ✅\n- `git diff --check` ✅\n-
`cargo test --locked --manifest-path arrow-data/Cargo.toml -p arrow-data --lib
test_try_extend_nulls_empty_union` ✅ (1 passed)\n- `cargo check --locked -p
arrow-data` ✅\n\nThe current implementation removes the separate empty-union
validation and runs the existing fallible union extension callback before
committing parent length/null-count/null-buffer state; zero-length extensions
remain no-ops. No additional code change was needed after these checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
