alamb commented on code in PR #11209:
URL: https://github.com/apache/arrow-rs/pull/11209#discussion_r4169079155
##########
arrow-data/src/transform/mod.rs:
##########
@@ -843,6 +843,16 @@ impl<'a> MutableArrayData<'a> {
));
}
+ if len == 0 {
+ return Ok(());
+ }
+
+ if matches!(&self.data.data_type, DataType::Union(fields, _) if
fields.is_empty()) {
Review Comment:
> No. The summary was written by me from the diff, review thread, and the
validation results; it was not copied verbatim from an LLM response. I will
keep future replies focused on the concrete code change and reproducible
command output.
Another point is that what commands your LLM ran locally to validate this is
not relevant to the review comments typically because the tests are run as part
of CI.
The point of us spending time reviewing your PR is to help both the project,
but also you as an engineer (and hopefully we'll find others who want to keep
helping us make DataFusion better)
We are more than capable of running coding agents ourselves and reviewing
their output and iterating with them, so we are trying to help others do so
rater than just eco the results here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
