HuaHuaY commented on code in PR #54582:
URL: https://github.com/apache/arrow/pull/54582#discussion_r4451911840
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -963,6 +963,9 @@ int64_t ColumnWriterImpl::RleEncodeLevels(const void*
src_buffer,
}
void ColumnWriterImpl::AddDataPage() {
+ if (num_buffered_values_ == 0) {
Review Comment:
It seems that every caller already checks `num_buffered_values_ > 0`, then
is this change still necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
