HuaHuaY commented on code in PR #54582:
URL: https://github.com/apache/arrow/pull/54582#discussion_r4451967382
##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -3144,6 +3144,73 @@ TEST(TestArrowReadWrite, ManySmallLists) {
default_arrow_writer_properties());
}
+TEST(TestArrowReadWrite, SingleRowRepeatedSmallPageSize) {
Review Comment:
In addition to `parquet-testing`, I suggest to add a unit test or extending
the existing tests, which specifically target the writer. This would prevent a
scenario where a regression in the behavior of the writer goes unnoticed
because the round-trip and `parquet-testing` tests still pass.
##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -3144,6 +3144,73 @@ TEST(TestArrowReadWrite, ManySmallLists) {
default_arrow_writer_properties());
}
+TEST(TestArrowReadWrite, SingleRowRepeatedSmallPageSize) {
Review Comment:
In addition to `parquet-testing`, I suggest to add a unit test or extend the
existing tests, which specifically target the writer. This would prevent a
scenario where a regression in the behavior of the writer goes unnoticed
because the round-trip and `parquet-testing` tests still pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
