sgilmore10 commented on a change in pull request #10305:
URL: https://github.com/apache/arrow/pull/10305#discussion_r657176867
##########
File path: matlab/CMakeLists.txt
##########
@@ -15,7 +15,8 @@
# specific language governing permissions and limitations
# under the License.
-cmake_minimum_required(VERSION 3.2)
+cmake_minimum_required(VERSION 3.20)
Review comment:
We wanted to use 3.20 because earlier versions of the FindMatlab.cmake
module had a few bugs we ran into when trying to build our mex functions. I'm
open to other approaches, but the hope was to build on the existing work of the
cmake community to avoid reinventing the wheel. We also want to share
improvements upstream where appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
