sgilmore10 commented on a change in pull request #10305:
URL: https://github.com/apache/arrow/pull/10305#discussion_r657178929
##########
File path: matlab/src/feather_reader.cc
##########
@@ -177,32 +182,34 @@ Status FeatherReader::Open(const std::string& filename,
*feather_reader = std::shared_ptr<FeatherReader>(new FeatherReader());
// Open file with given filename as a ReadableFile.
- std::shared_ptr<io::ReadableFile> readable_file(nullptr);
-
- RETURN_NOT_OK(io::ReadableFile::Open(filename, &readable_file));
+ arrow::Result<std::shared_ptr<io::ReadableFile>> maybe_readable_file =
+ io::ReadableFile::Open(filename);
+ RETURN_NOT_OK(maybe_readable_file);
// TableReader expects a RandomAccessFile.
- std::shared_ptr<io::RandomAccessFile> random_access_file(readable_file);
+ std::shared_ptr<io::RandomAccessFile> random_access_file{
+ maybe_readable_file.ValueOrDie()};
Review comment:
Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
