alamb opened a new pull request #533:
URL: https://github.com/apache/arrow-rs/pull/533


   # Which issue does this PR close?
   
   Built on https://github.com/apache/arrow-rs/pull/532 so review that one first
   
   Closes https://github.com/apache/arrow-rs/issues/529
   # Rationale for this change
    
   Arrow does not build today unless `rand 0.8` is included as another 
dependency of the project; I introduced this in #488 when I upgraded the rand 
dependency but disabled the default features (which require sys which mean 
arrow can't be built on webasm anymore)
   
   Since the only use of the `sys` part of the rand dependency is in benchmarks 
 and testing code, I propose simply not building that part of of the arrow 
crate if default features are turned off
   
   # What changes are included in this PR?
   1. Bring enough of the rand crate in by default to build, and `#ifdef` out 
their use when arrows default features are disabled
   
   # Are there any user-facing changes?
   There is a `test_utils` feature flag now, enabled by default, that gates 
what parts of arrow are compiled if the default features are turned off


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to