b41sh commented on pull request #706: URL: https://github.com/apache/arrow-rs/pull/706#issuecomment-904772781
> Thank you @b41sh -- I think this PR is looking quite good -- the code and changes are easy to understand and well tested. > > I do wonder about the name of these kernels as well as the need to have explicit "not matches" kernels. I am hoping for others to give feedback as well @alamb I have added some comment and remove function `regexp_not_matches_utf8`. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
