seddonm1 commented on a change in pull request #706:
URL: https://github.com/apache/arrow-rs/pull/706#discussion_r695227839
##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -450,6 +450,250 @@ pub fn nlike_utf8_scalar<OffsetSize:
StringOffsetSizeTrait>(
Ok(BooleanArray::from(data))
}
+/// Perform SQL `array ~ regex_array` operation on [`StringArray`] /
[`LargeStringArray`].
+pub fn regexp_matches_utf8<OffsetSize: StringOffsetSizeTrait>(
Review comment:
Agreed jorge, sorry I had missed this was being added at the Arrow crate
level. I had previously implemented the Postgres regex behavior in the
Datafusion layer and agree that due to differences in regex semantics maybe
this does not belong in the arrow-rs crate.
My main point would be from the user experience point of view it would be
good to implement the `'abcd' ~ 'bc'` style (even if this requires sqlparser
updates) rather than implement new non-standard SQL functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
