chriscasola commented on a change in pull request #11712:
URL: https://github.com/apache/arrow/pull/11712#discussion_r750566701
##########
File path: go/arrow/ipc/message.go
##########
@@ -154,11 +154,18 @@ type messageReader struct {
refCount int64
msg *Message
+
+ mem memory.Allocator
}
// NewMessageReader returns a reader that reads messages from an input stream.
-func NewMessageReader(r io.Reader) MessageReader {
- return &messageReader{r: r, refCount: 1}
+func NewMessageReader(r io.Reader, opts ...Option) MessageReader {
Review comment:
The use of the options pattern is a bit confusing in this library,
especially the `WithSchema` option, since in a lot of cases it's not optional
and the function will panic without it. In my opinion required things should be
real parameters.
I'm going to leave this as-is unless you feel strongly about making it a
normal parameter and are okay with the breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
