zeroshade commented on a change in pull request #11712:
URL: https://github.com/apache/arrow/pull/11712#discussion_r751413342
##########
File path: go/arrow/ipc/message.go
##########
@@ -154,11 +154,18 @@ type messageReader struct {
refCount int64
msg *Message
+
+ mem memory.Allocator
}
// NewMessageReader returns a reader that reads messages from an input stream.
-func NewMessageReader(r io.Reader) MessageReader {
- return &messageReader{r: r, refCount: 1}
+func NewMessageReader(r io.Reader, opts ...Option) MessageReader {
Review comment:
I agree with you on the `WithSchema` comment as far as for the writer
(it's not required for the reader which will read the schema from the stream,
and you only use `WithSchema` for asserting that you're reading a specific
schema).
For now we'll leave it, but after the release of v6.0.1 which will properly
tag this so that people can upgrade to v6, and people start using the tagged
releases, then i'll be comfortable making the breaking change since it would be
in a tagged *major release* that would make sense to allow a breaking change in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
