tustvold commented on a change in pull request #1082:
URL: https://github.com/apache/arrow-rs/pull/1082#discussion_r785493832
##########
File path: parquet/benches/arrow_array_reader.rs
##########
@@ -366,10 +366,10 @@ fn add_benches(c: &mut Criterion) {
mandatory_int32_column_desc.clone(),
);
count = bench_array_reader(array_reader);
+ assert_eq!(count, EXPECTED_VALUE_COUNT);
Review comment:
This was so that you can run a subset of the benchmarks, let me try
lifting them out of the iter block but still within the bench_function
:thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
