tustvold commented on a change in pull request #1082:
URL: https://github.com/apache/arrow-rs/pull/1082#discussion_r785499327
##########
File path: parquet/benches/arrow_array_reader.rs
##########
@@ -368,10 +366,10 @@ fn add_benches(c: &mut Criterion) {
mandatory_int32_column_desc.clone(),
);
count = bench_array_reader(array_reader);
- })
+ });
+ assert_eq!(count, EXPECTED_VALUE_COUNT);
Review comment:
This change allows for running a subset of the benchmarks, without this
the assertion fails if the bench function is filtered out.
For example, this would run just the string array benchmarks
```
cargo criterion --bench arrow_array_reader --features
test_common,experimental -- StringArray
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
