tustvold commented on a change in pull request #1082:
URL: https://github.com/apache/arrow-rs/pull/1082#discussion_r785498869
##########
File path: parquet/benches/arrow_array_reader.rs
##########
@@ -273,7 +274,7 @@ fn build_dictionary_encoded_string_page_iterator(
InMemoryPageIterator::new(schema, column_desc, pages)
}
-fn bench_array_reader(mut array_reader: impl ArrayReader) -> usize {
+fn bench_array_reader(mut array_reader: Box<dyn ArrayReader>) -> usize {
Review comment:
This change is necessary because byte_array_reader hides its
implementing type, this is both to make the API more ergonomic for clients and
also to aid future crate evolution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
