mosche commented on code in PR #22545:
URL: https://github.com/apache/beam/pull/22545#discussion_r941148593
##########
sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/publishing/InfluxDBPublisher.java:
##########
@@ -64,6 +64,13 @@ public static void publishNexmarkResults(
publishWithCheck(settings, () -> publishNexmark(results, settings, tags));
}
+ public static void publishTpcdsResults(
Review Comment:
My point here is that the `InfluxDBPublisher` abstraction is so poor that
you are forced to add a new interface method for every single new use case ...
the PR linked above fixes that for the JMH benchmarks. But it might be even
better to just use
https://mvnrepository.com/artifact/com.influxdb/influxdb-client-java and not
depend on these fairly broken `test-utils` at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
