aromanenko-dev commented on code in PR #22545:
URL: https://github.com/apache/beam/pull/22545#discussion_r942186865
##########
sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/publishing/InfluxDBPublisher.java:
##########
@@ -64,6 +64,13 @@ public static void publishNexmarkResults(
publishWithCheck(settings, () -> publishNexmark(results, settings, tags));
}
+ public static void publishTpcdsResults(
Review Comment:
I totally agree to have a good API for such internal tools but if every perf
test will use an own InfluxDB client implementation then it will be even worse,
imho. So, we need to have an own API for that (as we may conclude basing on
other parts of Beam that don't have...), though an internal implementation can
vary during the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
