mosche commented on code in PR #22545:
URL: https://github.com/apache/beam/pull/22545#discussion_r942203490
##########
sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/publishing/InfluxDBPublisher.java:
##########
@@ -64,6 +64,13 @@ public static void publishNexmarkResults(
publishWithCheck(settings, () -> publishNexmark(results, settings, tags));
}
+ public static void publishTpcdsResults(
Review Comment:
I agree, every (perf) test should use the very same InfluxDB client
implementation using ONE well defined interface. That's why this client CANNOT
be the current client. Copy pasting the same code over and over again to create
a somehow slightly different interface for the next test or creating a brand
new client is both just as bad.
I'm fixing that in https://github.com/apache/beam/pull/22260, but in the end
it just ends up very close to what the offical Java InfluxDB client does. So
why maintaining an "internal" API for InfluxDB at all? The official JAVA
InfluxDB client does all you need and is trivial to understand. Which isn't the
case with the current code! Figuring out how data ends up in InfluxDB is
impossible from looking at the interfaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
