damccorm commented on code in PR #25321: URL: https://github.com/apache/beam/pull/25321#discussion_r1102963348
########## sdks/python/apache_beam/ml/inference/pytorch_inference.py: ########## @@ -81,11 +81,8 @@ def _validate_constructor_args( def _load_model( - model_class: Optional[Callable[..., torch.nn.Module]], - state_dict_path: Optional[str], - device: torch.device, - model_params: Optional[Dict[str, Any]], - torch_script_model_path: Optional[str]): + model_class, state_dict_path, device, model_params, + torch_script_model_path): Review Comment: That's fine by me, can we leave the other type hints though? (we may still need to exclude state_dict_path for the same reason) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
