AnandInguva commented on code in PR #25321:
URL: https://github.com/apache/beam/pull/25321#discussion_r1103154016
##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -174,6 +174,12 @@ def update_model_path(self, model_path: Optional[str] =
None):
"""Update the model paths produced by side inputs."""
pass
+ def validate_constructor_args(self):
Review Comment:
At first I kept this in the Pytorch model handler class but there was a
suggestion at https://github.com/apache/beam/pull/25321#discussion_r1097855765.
I might have understood wrong but what i thought is that,
if we want to validate other handlers constructor args, lets share this
method in the base ModelHandler and other subclasses can implement if they want
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
