damccorm commented on code in PR #25321:
URL: https://github.com/apache/beam/pull/25321#discussion_r1103143757
##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -174,6 +174,12 @@ def update_model_path(self, model_path: Optional[str] =
None):
"""Update the model paths produced by side inputs."""
pass
+ def validate_constructor_args(self):
Review Comment:
Sorry for not seeing this earlier, but do we actually get anything out of
this being part of the base class? We're never going to call it from the base
and its implementation will always be subclass dependent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
