robinyqiu commented on a change in pull request #12202: URL: https://github.com/apache/beam/pull/12202#discussion_r456711570
########## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaCapableIOTableProviderWrapper.java ########## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.extensions.sql.meta.provider; + +import static org.apache.beam.sdk.util.RowJsonUtils.newObjectMapperWith; + +import com.alibaba.fastjson.JSONObject; +import com.fasterxml.jackson.core.JsonProcessingException; +import java.io.Serializable; +import org.apache.beam.sdk.annotations.Experimental; +import org.apache.beam.sdk.annotations.Internal; +import org.apache.beam.sdk.extensions.sql.impl.BeamTableStatistics; +import org.apache.beam.sdk.extensions.sql.meta.BaseBeamTable; +import org.apache.beam.sdk.extensions.sql.meta.BeamSqlTable; +import org.apache.beam.sdk.extensions.sql.meta.Table; +import org.apache.beam.sdk.options.PipelineOptions; +import org.apache.beam.sdk.schemas.Schema; +import org.apache.beam.sdk.schemas.io.InvalidConfigurationException; +import org.apache.beam.sdk.schemas.io.InvalidSchemaException; +import org.apache.beam.sdk.schemas.io.SchemaIO; +import org.apache.beam.sdk.schemas.io.SchemaIOProvider; +import org.apache.beam.sdk.transforms.PTransform; +import org.apache.beam.sdk.util.RowJson; +import org.apache.beam.sdk.values.PBegin; +import org.apache.beam.sdk.values.PCollection; +import org.apache.beam.sdk.values.POutput; +import org.apache.beam.sdk.values.Row; + +/** + * A general {@link TableProvider} for IOs for consumption by Beam SQL. + * + * <p>Can create child classes for IOs to pass {@link #getSchemaIOProvider()} that is specific to + * the IO. + */ +@Internal +@Experimental +public abstract class SchemaCapableIOTableProviderWrapper extends InMemoryMetaTableProvider + implements Serializable { + public abstract SchemaIOProvider getSchemaIOProvider(); + + @Override + public String getTableType() { + return getSchemaIOProvider().identifier(); + } + + @Override + public BeamSqlTable buildBeamSqlTable(Table tableDefinition) { + JSONObject tableProperties = tableDefinition.getProperties(); + + try { + RowJson.RowJsonDeserializer deserializer = + RowJson.RowJsonDeserializer.forSchema(getSchemaIOProvider().configurationSchema()) + .withNullBehavior(RowJson.RowJsonDeserializer.NullBehavior.ACCEPT_MISSING_OR_NULL); + + Row configurationRow = + newObjectMapperWith(deserializer).readValue(tableProperties.toString(), Row.class); + + SchemaIO schemaIO = + getSchemaIOProvider() + .from(tableDefinition.getLocation(), configurationRow, tableDefinition.getSchema()); + + return new SchemaIOTableWrapper(schemaIO); + } catch (InvalidConfigurationException | InvalidSchemaException e) { + throw new InvalidTableException(e.getMessage()); + } catch (JsonProcessingException e) { + throw new AssertionError( + "Failed to re-parse TBLPROPERTIES JSON " + tableProperties.toString()); + } + } + + private BeamTableStatistics getTableStatistics(PipelineOptions options) { + if (isBounded().equals(PCollection.IsBounded.BOUNDED)) { + return BeamTableStatistics.BOUNDED_UNKNOWN; + } + return BeamTableStatistics.UNBOUNDED_UNKNOWN; + } + + private PCollection.IsBounded isBounded() { + return getSchemaIOProvider().isBounded(); + } + + /** A generalized {@link Table} for IOs to create IO readers and writers. */ Review comment: `Table` should be `BeamSqlTable` here. `Table` is actually a class for config, I think we should rename it to something like `TableDefinition` later... It is very confusing to me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
