kennknowles commented on pull request #12202:
URL: https://github.com/apache/beam/pull/12202#issuecomment-658358581


   I think Luke said the same thing. You put `TableProvider` interface 
somewhere everyone can depend on. I believe in your proposal it might end up in 
up in java core. I don't know if that is necessary or not. I know there were 
revisions planned to make that more appropriate. Then the implementations 
depend on core, and the place that wants to load them also depends on core.
   
   BTW it would be better as a `TableProviderRegistrar` so that it decouples 
the provider interface from the loading/registration logic. Then SQL depends on 
that


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to