apilloud commented on a change in pull request #12389:
URL: https://github.com/apache/beam/pull/12389#discussion_r470752028
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java
##########
@@ -679,6 +714,20 @@ private static Object convertAvroArray(
return ret;
}
+ private static Object convertAvroMap(
+ FieldType beamField, Object value, BigQueryUtils.ConversionOptions
options) {
+ List<GenericData.Record> records = (List<GenericData.Record>) value;
+ HashMap<Object, Object> ret = new HashMap<>();
Review comment:
We prefer to use ImmutableMap when possible, there are examples in this
file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
