apilloud commented on a change in pull request #12389:
URL: https://github.com/apache/beam/pull/12389#discussion_r470756034
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java
##########
@@ -263,6 +267,18 @@ private static FieldType fromTableFieldSchemaType(
"SqlTimestampWithLocalTzType", FieldType.STRING, "",
FieldType.DATETIME) {});
case "STRUCT":
case "RECORD":
+ // check if record represents a map entry
Review comment:
This is something that is going to need more discussion. I have two
concerns:
1. The ZetaSQL dialect doesn't support map types, so this will break that
use case.
2. The user might have a row matching this struct that isn't suppose to be a
map.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
