m-trieu commented on code in PR #31317: URL: https://github.com/apache/beam/pull/31317#discussion_r1613964582
########## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/ExecutionState.java: ########## @@ -22,10 +22,19 @@ import org.apache.beam.runners.core.metrics.ExecutionStateTracker; import org.apache.beam.runners.dataflow.worker.DataflowWorkExecutor; import org.apache.beam.runners.dataflow.worker.StreamingModeExecutionContext; +import org.apache.beam.sdk.annotations.Internal; import org.apache.beam.sdk.coders.Coder; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; @AutoValue -public abstract class ExecutionState { +@Internal +public abstract class ExecutionState implements AutoCloseable { Review Comment: I think it will be worth exploring cleaning up StreamingModeExecutionContext + ExecutionState looks like `streaming.worker.ExecutionState` (there is another execution state StreamingModeExecutionState which extends `DataflowExecutionState` which extends `core.metrics.ExecutionState` which seems more for metric sampling) There could be a lot of clean up here Added a comment and TODO to clean up as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org