m-trieu commented on code in PR #31317:
URL: https://github.com/apache/beam/pull/31317#discussion_r1614002144
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/StreamingEngineClient.java:
##########
@@ -97,18 +104,19 @@ public final class StreamingEngineClient {
private StreamingEngineClient(
JobHeader jobHeader,
GetWorkBudget totalGetWorkBudget,
- AtomicReference<StreamingEngineConnectionState> connections,
GrpcWindmillStreamFactory streamFactory,
- WorkItemProcessor workItemProcessor,
+ WorkItemScheduler workItemScheduler,
ChannelCachingStubFactory channelCachingStubFactory,
GetWorkBudgetDistributor getWorkBudgetDistributor,
GrpcDispatcherClient dispatcherClient,
- long clientId) {
+ long clientId,
+ Function<WindmillStream.CommitWorkStream, WorkCommitter>
workCommitterFactory,
+ Consumer<List<Windmill.ComputationHeartbeatResponse>>
heartbeatResponseProcessor) {
this.jobHeader = jobHeader;
this.started = new AtomicBoolean();
Review Comment:
finish method (like stop in StreamingDataflowWorker) is only there for
testing so i added annotation there as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
