LEEKYE commented on code in PR #35120:
URL: https://github.com/apache/beam/pull/35120#discussion_r2132880887
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ExecutionStateSampler.java:
##########
@@ -65,6 +66,7 @@ public class ExecutionStateSampler {
private static final Logger LOG =
LoggerFactory.getLogger(ExecutionStateSampler.class);
private static final int DEFAULT_SAMPLING_PERIOD_MS = 200;
private static final long MAX_LULL_TIME_MS = TimeUnit.MINUTES.toMillis(5);
+ private static final int MIN_LULL_TIME_MINUTE_FOR_RESTART = 10; // Open to
change.
Review Comment:
> we may document in pipeline options that only values >= 10 are honored
Some discussion may be needed to determine the number. But as there is
already a 5-minute Max_LULL_TIME_MS, this number should be greater than 5
minutes. What I am curious is that will it take so long to process only one
element in a transition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
