LEEKYE commented on code in PR #35120:
URL: https://github.com/apache/beam/pull/35120#discussion_r2136166416
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ExecutionStateSampler.java:
##########
@@ -357,6 +377,19 @@ private void takeSample(long currentTimeMillis, long
millisSinceLastSample) {
transitionsAtLastSample = transitionsAtThisSample;
} else {
long lullTimeMs = currentTimeMillis - lastTransitionTimeMillis.get();
+
+ try {
Review Comment:
> People who are more familiar with this path may answer:
>
> Will `lullTimeMs` give the intended value? It sounds to me this is some
sample interval, not necessary PTransform latency
I would say it's more like, used to check if the process is stuck in one
transition for too long, so the name ptransform_timeout_duration might not be
appropriate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
