Abacn commented on code in PR #35120:
URL: https://github.com/apache/beam/pull/35120#discussion_r2132942441
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptions.java:
##########
@@ -424,4 +424,16 @@ public String create(PipelineOptions options) {
return String.format("%s/%s", info.getName(),
info.getVersion()).replace(" ", "_");
}
}
+
+ /**
+ * The time limit (minute) that an SDK worker allows for a PTransform
operation before signaling
+ * the runner harness to restart the SDK worker.
+ */
+ @Default.Integer(Integer.MAX_VALUE)
Review Comment:
It's more than code style. Pipeline can have transforms come from different
SDK language, and pipeline options are mapped (javaSmallCamel <->
python_or_go_snake). I didn't test what would happen if they have different
default value but to avoid surprise just good to have a value to disable the
new option among all SDKs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
