lostluck commented on code in PR #35337:
URL: https://github.com/apache/beam/pull/35337#discussion_r2153032741
##########
sdks/go/pkg/beam/runners/prism/internal/stage.go:
##########
@@ -208,8 +208,8 @@ progress:
ticked = true
resp, err := b.Progress(ctx, wk)
if err != nil {
- slog.Debug("SDK Error from progress, aborting
progress", "bundle", rb, "error", err.Error())
- break progress
+ slog.Debug("SDK Error from progress request,
aborting progress update", "bundle", rb, "error", err.Error())
+ continue progress
Review Comment:
I do think we want to do this. BUT we should still stop the ticker from
triggering too. Progress is an RPC that must never fail, so it shouldn't be
returning an error here.
Technically, in this case, it's just "shut off the progTick" then continue.
```suggestion
progTick.Stop()
continue progress
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
